improvements to the tests, and added testing to the pipeline. Now a package won't publish if it doesn't test :)

.github/workflows/python-publish.yml

@@ -22,6 +22,9 @@ jobs:
       run: |
         python -m pip install --upgrade pip
         pip install setuptools wheel twine
+    - name: Test #TODO use a testing solution that won't be deprecated soon
+      run: |
+        python setup.py test
     - name: Build and publish
       env:
         TWINE_USERNAME: ${{ secrets.PYPI_USERNAME }}

.github/workflows/python-test.yml

@@ -0,0 +1,21 @@
+name: Unit test runner
+
+on: push
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: '3.x'
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install setuptools wheel twine
+      - name: Test #TODO use a testing solution that won't be deprecated soon
+        run: |
+          python setup.py test
+

TODO.md

@@ -0,0 +1,3 @@
+# TODO
+
+1: add proper versioning (usage of tags during publish pipeline)

setup.py

@@ -4,8 +4,11 @@ with open("README.md", "r", encoding="utf-8") as fh:
     long_description = fh.read()
 
 setuptools.setup(
-    name="vault-db-bvanroll", # Replace with your own username
+    name="vaultdb",
     version="0.0.1",
+    version_config=True,
+    test_suite="test",
+    setup_requires=['setuptools-git-versioning'],
     author="Beppe Vanrolleghem",
     author_email="beppe.vanrolleghem@gmail.com",
     description="A vault creds reader for the vault database engine",
@@ -20,7 +23,7 @@ setuptools.setup(
         "License :: OSI Approved :: MIT License",
         "Operating System :: OS Independent",
     ],
-    package_dir={"": "vaultdatabaseengine"},
+    package_dir={"": "src"},
     packages=setuptools.find_packages(where="src"),
     python_requires=">=3.6",
 )

test/__init__.py

@@ -0,0 +1,7 @@
+import unittest
+
+
+
+
+if __name__ == '__main__':
+    unittest.main()

test/database.py

@@ -1,36 +0,0 @@
-import unittest
-import sys
-import os
-sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
-import vaultdatabaseengine
-
-class MyTestCase(unittest.TestCase):
-    def test_psql(self):
-        #TODO exec psql connect
-        print("hi")
-        test = vaultdatabaseengine.Database()
-        test.check_valid()
-        self.assertEqual(test.valid, False)
-
-    def test_psql_invalid_vault_url(self):
-        #TODO figure out how to fail unit test check
-        try:
-            vaultdatabaseengine.Database(dbname="sdfk", vault_url="localhost", vault_port=8200, token="bla")
-        except:
-            print("did it")
-            return
-
-    def test_psql_invalid_vault_port(self):
-        try:
-            vaultdatabaseengine.Database(dbname="sdfk", vault_url="localhost", vault_port="a", token="bla")
-        except:
-            return
-
-    def test_psql_valid(self):
-        print(vaultdatabaseengine.Database(dbname="psql", vault_url="http://localhost", token="s.GoR2nisHPeKU1vOaw9hZ5L7h").get_creds())
-
-
-
-
-if __name__ == '__main__':
-    unittest.main()

test/test_database.py

@@ -0,0 +1,51 @@
+import unittest
+import sys
+import os
+sys.path.insert(0, os.path.abspath(os.path.join(os.path.dirname(__file__), '..')))
+import src
+
+class DatabaseClassTests(unittest.TestCase):
+
+    def test_vault_connection_error(self):
+        #TODO give some "valid" url
+        self.fail()
+
+    def test_vault_non_existent_database(self):
+        #TODO test non existent_database
+        self.fail()
+
+    def test_psql_connection(self):
+        #TODO exec psql connect
+        print("hi")
+        test = src.Database()
+        test.check_valid()
+        self.assertEqual(test.valid, False)
+
+    def test_psql_invalid_vault_url(self):
+        try:
+            src.Database(dbname="sdfk", vault_url="localhost", vault_port=8200, token="bla")
+        except:
+            #TODO check the err msg
+            return
+        else:
+            self.fail()
+
+
+    def test_psql_invalid_vault_port(self):
+        try:
+            src.Database(dbname="sdfk", vault_url="localhost", vault_port="a", token="bla")
+        except:
+            #TODO check the error message
+            return
+        else:
+            self.fail()
+
+
+    def test_psql_valid(self):
+        print(src.Database(dbname="psql", vault_url="http://localhost", token="s.GoR2nisHPeKU1vOaw9hZ5L7h").get_creds())
+
+
+
+
+if __name__ == '__main__':
+    unittest.main()